Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vue3: API Key Create Page: vertical spacing issue #11749

Closed
wants to merge 1 commit into from
Closed

Vue3: API Key Create Page: vertical spacing issue #11749

wants to merge 1 commit into from

Conversation

aalves08
Copy link
Member

@aalves08 aalves08 commented Aug 28, 2024 •
edited
Loading

Summary

Fixes #11720

Occurred changes and/or fixed issues

  • add v-bind="$attrs" to outermost container of LabeledSelect

Technical notes summary

Problem was that the class mt-20 that was specified in the view for the api key https://github.com/rancher/dashboard/blob/master/shell/edit/token.vue#L188-L193 was not being passed to the component.
Screenshot 2024-08-28 at 16 44 10

I think that I applied the correct fix, but someone with more experience on the Vue3 migration should chime in as a reviewer, because of possible unwanted side-effects.

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aalves08 aalves08 added the area/vue3 Bugs and technical debts as outcome to the Vue3 migration label Aug 28, 2024
@aalves08 aalves08 added this to the v2.10.0 milestone Aug 28, 2024
@aalves08 aalves08 self-assigned this Aug 28, 2024
@aalves08 aalves08 force-pushed the 11720-api-keys-vertical-space-broken branch from 6c8d147 to a478a84 Compare August 30, 2024 08:23
@aalves08
Copy link
Member Author

Closing, because it got fixed with aalves08@47217a4

@aalves08 aalves08 closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rak-phillip rak-phillip rak-phillip approved these changes

Assignees

@aalves08 aalves08

Labels
area/vue3 Bugs and technical debts as outcome to the Vue3 migration
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.

Vue3: API Key Create Page: vertical spacing issue
2 participants
@aalves08 @rak-phillip